Draft For-User-Agent implementation #782
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # tracing-okhttp3/src/main/java/com/palantir/tracing/OkhttpTraceInterceptor2.java # tracing-okhttp3/src/main/java/com/palantir/tracing/okhttp3/OkhttpTraceInterceptor.java # tracing/src/main/java/com/palantir/tracing/Trace.java # tracing/src/main/java/com/palantir/tracing/Tracer.java
OStevan
added
enhancement
carterkozak
reviewed
Sep 30, 2021
There was a problem hiding this comment.
Took a quick scan over this (not terribly thorough). Before implementing this I think we should factor out common tracing state (information which applies to a trace, not individual spans) into a single object that's shared between Trace and DetachedSpan (e.g. traceId and requestId). That way features like this one don't require so much plumbing.
| @Deprecated | ||
| String ORIGINATING_SPAN_ID = "X-OrigSpanId"; | ||
|
|
||
| String FOR_USER_AGENT = "X-For-User-Agent"; |
There was a problem hiding this comment.
nit: X- prefixes were deprecated several years ago in RFC 6648
Comment on lines
+51
to
+54
| /** | ||
| * The Key under which origin user agents are inserted into SLF4J {@link org.slf4j.MDC MDCs}. | ||
| */ | ||
| public static final String FOR_USER_AGENT_KEY = "__forUserAgent"; |
There was a problem hiding this comment.
I don't think this belongs in the MDC, we can find it based on the requestId
|
Closing in favor of #790 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
In this draft tracing-java propagates an additional header across requests which will contain the user agent which was originally used to send a request.
Questions:
Tests are missing